Now that i have wired up the start and kill switch and connected a battery the engine turns over but i have no spark
what things can cause no spark?
as according to the wiring diagram they are connected properly
I've been studying this wiring diagram:
http://www.gsx-r250.com/down/suzuki_gsxr250_el_diagram_en.pdf
Your Ignition switch needs to be sending power to the (+) inputs of both Ignition coils with its Orange wire.
The black/white wire to your CDI box needs to be grounded.
There's a Black/yellow wire from your CDI box that needs to go to the negative terminal of 1 coil.
The CDI box also has a White wire that goes to the negative terminal of the other coil.
The Green/White, Black/Blue and Brown wires from your CDI box run to the Ignition pickup inside your engine.
The Orange/white wire coming from your CDI box is the output from your kill switch. This wire needs to get power for the CDI to work. The Orange/Black wire
going to your kill switch is where your whole kickstand safety circuit is wired in. All this safety system seems to do is cut-off power to the Orange/Black wire that supplies power to the kill switch, so It should be fairly simple to bypass if you simply connect your kill switch directly to the ignition switch output that gets power when switched on.
I'd suggest you mount your Ignition coils and CDI box to your karts frame, just in case they require a source of ground through their mounting brackets.